fix: wire up cron again #3452
Merged
fix: wire up cron again #3452
+260
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
requested review from
wesbillman
and removed request for
a team
stuartwdouglas
added
the
run-all
This was referenced Nov 21, 2024
Open
Open
stuartwdouglas
force-pushed
the
stuartwdouglas/cron-service
branch
4 times, most recently
from
586e571
to
9302944
Compare
alecthomas
approved these changes
Nov 24, 2024
cmd/ftl-cron/main.go
Outdated
| err = observability.Init(ctx, false, "", "ftl-cron", ftl.Version, cli.ObservabilityConfig) | ||
| kctx.FatalIfErrorf(err, "failed to initialize observability") | ||
|
|
||
| verbClient := rpc.Dial(ftlv1connect.NewVerbServiceClient, cli.ProvisionerConfig.ControllerEndpoint.String(), log.Error) |
There was a problem hiding this comment.
Verb calls shouldn't be routing through the Provisioner...?
There was a problem hiding this comment.
oops, that was a copy/paste error I should have picked up.
cmd/ftl-cron/main.go
Outdated
| Version kong.VersionFlag `help:"Show version."` | ||
| ObservabilityConfig observability.Config `embed:"" prefix:"o11y-"` | ||
| LogConfig log.Config `embed:"" prefix:"log-"` | ||
| ProvisionerConfig provisioner.Config `embed:""` |
There was a problem hiding this comment.
Verb calls should be routing through the Controller.
stuartwdouglas
force-pushed
the
stuartwdouglas/cron-service
branch
from
9302944
to
4abd074
Compare
alecthomas
reviewed
Nov 24, 2024
| Version kong.VersionFlag `help:"Show version."` | ||
| ObservabilityConfig observability.Config `embed:"" prefix:"o11y-"` | ||
| LogConfig log.Config `embed:"" prefix:"log-"` | ||
| CronConfig cron.Config `embed:""` |
There was a problem hiding this comment.
In general we should prefix all embedded configs.
There was a problem hiding this comment.
That is not the pattern we have been using for the 'main' config though. Cron, Runner, Provisioner, Controller etc all have one 'main' config that is not prefixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.